[COMPRESS-664] Return null value from getNextEntry() for empty file #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix regression error in case when getNextEntry() method is invoked on empty file (zero size) to get first entry. Till version 1.25.0, null value was returned (like is done in standard java ZipInputStream too). The regression was caused by implementing 'Support preamble garbage in ZipArchiveInputStream' feature (PR 471). - #471
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #486 +/- ##
=========================================
Coverage 80.76% 80.77%
- Complexity 6801 6830 +29
=========================================
Files 348 348
Lines 24945 25007 +62
Branches 4029 4034 +5
=========================================
+ Hits 20148 20200 +52
- Misses 3269 3283 +14
+ Partials 1528 1524 -4 ☔ View full report in Codecov by Sentry. |
garydgregory
changed the title
asfgit
pushed a commit
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression error in case when getNextEntry() method is invoked on empty file (zero size) to get first entry. Till version 1.25.0, null value was returned (like is done in standard java ZipInputStream too). The regression was caused by implementing 'Support preamble garbage in ZipArchiveInputStream' feature (PR 471).