[FLINK-36177] Deprecate KafkaShuffle and more #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AHeise
force-pushed
the
FLINK-36177-deprecate-kafkashuffle
branch
from
1b914b3 to
8894547
Compare
This commit deprecates all classes that are slated for removal in the kafka-4.0 release compatible with Flink 2.0. I also deprecated internal classes to make later removal easier. Some public classes will cease to be public API but are still internally used.
AHeise
force-pushed
the
FLINK-36177-deprecate-kafkashuffle
branch
from
8894547 to
ced8771
Compare
fapaul
reviewed
Sep 27, 2024
...main/java/org/apache/flink/streaming/connectors/kafka/partitioner/FlinkKafkaPartitioner.java
Show resolved
Hide resolved
…oner Relocate FlinkKafkaPartitioner to KafkaSink package and turn it into a functional interface.
AHeise
force-pushed
the
FLINK-36177-deprecate-kafkashuffle
branch
from
ced8771 to
fee54fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit deprecates all classes that are slated for removal in the kafka-4.0 release compatible with Flink 2.0. I also deprecated internal classes to make later removal easier. Some public classes will cease to be public API but are still internally used.
Also introduce KafkaPartitioner to replace FlinkKafkaPartitioner. Relocate FlinkKafkaPartitioner to KafkaSink package and turn it into a functional interface.
Tentative timeline: