nimble: btshell: Fix multiple issues #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariuszSkamra
commented
Nov 18, 2024
| @@ -637,8 +639,7 @@ ble_svc_audio_bass_remove_source(uint8_t *data, uint16_t data_len, uint16_t conn | |||
| os_memblock_put(&ble_audio_svc_bass_metadata_pool, rcv_state->state.subgroups[i].metadata); | |||
| } | |||
|
|
|||
| memset(rcv_state, 0, sizeof(*rcv_state)); | |||
There was a problem hiding this comment.
This one was invalid actually, as we lost state->chr_val after this operation, fixed now
MariuszSkamra
force-pushed
the
leaudio_fixes
branch
2 times, most recently
from
1221e95 to
4cbeb67
Compare
MariuszSkamra
commented
Nov 18, 2024
| @@ -4235,7 +4235,7 @@ static const struct shell_cmd_help sync_stats_help = { | |||
| #endif | |||
| #endif | |||
|
|
|||
| #if MYNEWT_VAL(BLE_ISO_BROADCAST_SOURCE) | |||
| #if MYNEWT_VAL(BLE_AUDIO) && MYNEWT_VAL(BLE_ISO_BROADCAST_SOURCE) | |||
There was a problem hiding this comment.
We should have a dedicated syscfg option like BLE_AUDIO_BROADCAST_SOURCE actually IMO
This fixes audio shell functionality not being compiled.
This fixes various compilation issues related to usage of invalid format
specifiers. Tested on native and nrf5340.
repos/apache-mynewt-nimble/apps/btshell/src/cmd_leaudio.c:724:39: error: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
724 | console_printf("broadcast_id=0x%06x adv_sid=%d adv_addr_type=%s adv_addr=",
| ~~~^
| |
| unsigned int
| %06lx
725 | source_desc->broadcast_id, source_desc->adv_sid,
| ~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| uint32_t {aka long unsigned int}
cc1: all warnings being treated as errors
This fixes duplicated code by using ble_svc_audio_bass_receive_state_free function when Receive State instance is cleared.
This fixes the parameters length check and simplifies the buffer operations a bit.
This removes unused header include.
This fixes building ISO Broadcast Source enabled target with BLE Audio functionality disabled.
This adds 'broadcast-sink-set-sync-params' commands to be used to set the PA Sync parameters to be used.
This fixes btshell application compilation errors with SHELL_CMD_HELP option disabled.
This adds Broadcast Sink and Scan Delegator to CI syscfg to build all applications with those options enabled.
MariuszSkamra
force-pushed
the
leaudio_fixes
branch
from
4cbeb67 to
86e58fa
Compare
sjanc
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes multiple issues found during tests in btshell and BASS