Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provisioner remove dependency of marco BLE_MESH_CDB #1939

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

gavin-yy
Copy link
Contributor

@gavin-yy gavin-yy commented Dec 2, 2024

currently the provisioner feature depends on marco BLE_MESH_CDB. This dependency seems not be expected ?
This commit is trying to remove this dependency. Then the shell demo for linux as a mesh provisioner role without BLE_MESH_CDB and BLE_MESH_SETTINGS works.

BTW, BLE_MESH_CDB depends on BLE_MESH_SETTINGS, if BLE_MESH_SETTINGS is not enabled, it cause compiling error.
static void schedule_cdb_store(int flag)
{
atomic_set_bit(bt_mesh_cdb.flags, flag);
bt_mesh_settings_store_schedule(BT_MESH_SETTINGS_CDB_PENDING);
}
nimble/host/mesh/src/cdb.c:545: undefined reference to `bt_mesh_settings_store_schedule'

@github-actions github-actions bot added host size/S Small PR labels Dec 2, 2024
@github-actions github-actions bot added the size/XL Extra large PR label Dec 10, 2024
@sjanc
Copy link
Contributor

sjanc commented Dec 11, 2024

syscfg.yml and pkg.yml are mynewt specifics, those are not needed for linux port (as this is build with make)

@gavin-yy
Copy link
Contributor Author

The coding style checking progress seems have some problem...

it print some errors according above links, it runs without problem in my local repo when pushing commit :

Run ./repos/apache-mynewt-core/.github/check_style.py
Option: at uncrustify.cfg:147: Expected number , for 'indent_shift'; got 'false'
uncrustify.cfg:186: option 'indent_sing_line_comments' is deprecated; did you want to use 'indent_single_line_comments_before' instead?
Option: at uncrustify.cfg:231: Expected number , for 'indent_comma_paren'; got 'false'
Option: at uncrustify.cfg:234: Expected number , for 'indent_bool_paren'; got 'false'

Copy link
Contributor

@sjanc sjanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we need to update uncrustify config (probaly ubuntu-latest on gihub was bumped)

@sjanc sjanc merged commit 895ed28 into apache:master Dec 23, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host size/S Small PR size/XL Extra large PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants