-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mm: make the alignment length in mm consistent with Kasan #15397
base: master
Are you sure you want to change the base?
Conversation
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. While it provides a title and attempts to address the summary and impact, it lacks crucial details and proper formatting. Here's a breakdown of what's missing:
To be accepted, the PR needs significant revision to address these shortcomings. The submitter must:
In short, the PR needs more context, detail, and evidence of testing to meet the NuttX requirements. |
#define KASAN_SHADOW_SIZE(size) \ | ||
(KASAN_BYTES_PER_WORD * ((size) / KASAN_SHADOW_SCALE / KASAN_BITS_PER_WORD)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about remove KASAN_SHADOW_SCALE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After aligning the prefix and structure, mm and kasan can share the same ALIGN, or write
#define KASAN_SHADOW_SCALE MM_ALIGN
preceding will cause the mm alignment to be inconsistent with the kasan alignment Signed-off-by: wangmingrong1 <wangmingrong1@xiaomi.com>
union | ||
{ | ||
mmsize_t preceding; /* Physical preceding chunk size */ | ||
uint8_t align[MM_ALIGN]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where extend mm_allocnode_s?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expanded by the last
struct mm_allocnode_s
{
xxxxx;
}aligned_data(MM_ALIGN);
Summary
Impact
Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.
Testing
Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.