Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm/stm32ldiscovery: Update the chrono defconfig #15423

Closed
wants to merge 1 commit into from

Conversation

lupyuen
Copy link
Member

@lupyuen lupyuen commented Jan 4, 2025

Summary

CONFIG_EXAMPLES_CHRONO and CONFIG_EXAMPLES_SLCD are no longer needed in the defconfig for stm32ldiscovery:chrono, due to:

This PR removes CONFIG_EXAMPLES_CHRONO and CONFIG_EXAMPLES_SLCD from stm32ldiscovery:chrono

$ tools/refresh.sh --silent stm32ldiscovery:chrono
  Normalize stm32ldiscovery:chrono
< CONFIG_EXAMPLES_CHRONO=y
< CONFIG_EXAMPLES_SLCD=y

Impact

Before this PR: CI Job arm-12 fails the defconfig validation for stm32ldiscovery:chrono.

After this PR: CI Job arm-12 will complete successfully.

Testing

Before The PR

CI Job arm-12 fails the defconfig validation for stm32ldiscovery:chrono, as reported by nuttx-dashboard.org
https://gitlab.com/lupyuen/nuttx-build-log/-/snippets/4789583#L621

Configuration/Tool: stm32ldiscovery/chrono,CONFIG_ARM_TOOLCHAIN_CLANG
  Normalize stm32ldiscovery/chrono
< CONFIG_EXAMPLES_CHRONO=y
< CONFIG_EXAMPLES_SLCD=y

After The PR

CI Job arm-12 completes successfully, tested with Docker
https://gist.github.com/lupyuen/dfddc63bafe0b2c4dd9f4f52d6b12598

sudo docker run \
  -it \
  ghcr.io/apache/nuttx/apache-nuttx-ci-linux:latest \
  /bin/bash
cd
git clone https://github.com/lupyuen2/wip-nuttx nuttx --branch stm32ldiscovery-chrono
git clone https://github.com/apache/nuttx-apps apps
pushd nuttx ; echo NuttX Source: https://github.com/apache/nuttx/tree/$(git rev-parse HEAD) ; popd
pushd apps  ; echo NuttX Apps: https://github.com/apache/nuttx-apps/tree/$(git rev-parse HEAD) ; popd
cd nuttx/tools/ci
./cibuild.sh -c -A -N -R testlist/arm-12.dat 

NuttX Source: https://github.com/apache/nuttx/tree/e40244893c372f4d8e8a6c507f8d5af1a35f2df0
NuttX Apps: https://github.com/apache/nuttx-apps/tree/2cfbdbb4015aeec4a4579891d85bd09e4cdc5b78
Configuration/Tool: stm32ldiscovery/chrono,CONFIG_ARM_TOOLCHAIN_CLANG
Normalize stm32ldiscovery/chrono
[ No Errors ]

`CONFIG_EXAMPLES_CHRONO` and `CONFIG_EXAMPLES_SLCD` are no longer needed in the defconfig for `stm32ldiscovery:chrono`, due to:
- apache/nuttx-apps#2926

This PR removes `CONFIG_EXAMPLES_CHRONO` and `CONFIG_EXAMPLES_SLCD` from `stm32ldiscovery:chrono`
```bash
$ tools/refresh.sh --silent stm32ldiscovery:chrono
  Normalize stm32ldiscovery:chrono
< CONFIG_EXAMPLES_CHRONO=y
< CONFIG_EXAMPLES_SLCD=y
```
@github-actions github-actions bot added Board: arm Size: XS The size of the change in this PR is very small labels Jan 4, 2025
@lupyuen lupyuen marked this pull request as ready for review January 4, 2025 01:23
@xiaoxiang781216
Copy link
Contributor

@lupyuen it's better to enable the dependence to bring back CONFIG_EXAMPLES_CHRONO.

Copy link
Member

@raiden00pl raiden00pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add CONFIG_SLCD=y here instead removing these, otherwise this config doesn't make sense :)

@lupyuen lupyuen closed this Jan 4, 2025
yf13 pushed a commit to yf13/nuttx that referenced this pull request Jan 6, 2025
This is to unblock CI check,
https://github.com/apache/nuttx/actions/runs/12628628318/job/35185115826

following suggestion per:
apache#15423 (review)

Signed-off-by: Yanfeng Liu <p-liuyanfeng9@xiaomi.com>
@xiaoxiang781216
Copy link
Contributor

Fixed here: #15427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Board: arm Size: XS The size of the change in this PR is very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants