Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add list/copy/rename for dropbox #4424

Merged
merged 7 commits into from
Apr 15, 2024
Merged

Conversation

zjregee
Copy link
Member

@zjregee zjregee commented Apr 2, 2024

fix: #4388

@zjregee
Copy link
Member Author

zjregee commented Apr 2, 2024

I've done some testing locally.

It seems we can't do a full CI test on Dropbox before merging it.

@Xuanwo
Copy link
Member

Xuanwo commented Apr 2, 2024

It seems we can't do a full CI test on Dropbox before merging it.

It will be possible after you becoming an OpenDAL committer 💌

@Xuanwo
Copy link
Member

Xuanwo commented Apr 2, 2024

This is a refactor to simplify the implementation of this feature. Would you be willing to wait a couple of days?

@zjregee
Copy link
Member Author

zjregee commented Apr 2, 2024

Got this, I'd like to mark this to draft first.

@zjregee zjregee marked this pull request as draft April 2, 2024 08:03
@Xuanwo
Copy link
Member

Xuanwo commented Apr 10, 2024

Hi, @zjregee, sorry for the waiting. Would you like to merge with main and try again?

@zjregee
Copy link
Member Author

zjregee commented Apr 14, 2024

Updated.

@zjregee zjregee marked this pull request as ready for review April 14, 2024 15:50
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit a24026d into apache:main Apr 15, 2024
69 checks passed
@zjregee zjregee deleted the update-dropbox branch April 15, 2024 01:58
@zjregee zjregee mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement list, copy and rename for services-dropbox
2 participants