feat(bindings/nodejs): generate types and add typed create_operator method #5465
Conversation
trim21
force-pushed
the
gen-ts
branch
2 times, most recently
from
10ec06d to
7f4176a
Compare
|
|
||
| # NOTE: this is the feature we used to build pypi wheels. | ||
| # When enable or disable some features, | ||
| # also need to update dev/src/generate/binding_nodejs.rs `enabled_service` to match it. |
There was a problem hiding this comment.
We have repeated this pattern once again. Let's implement a utility function to retrieve all enabled services by cargo metadata.
| value_field?: string | ||
| } | ||
|
|
||
| export interface Redb_Config { |
There was a problem hiding this comment.
Is it normal for js to jave types like Xxx_Yyy? Should we use XxxYyy instead?
There was a problem hiding this comment.
we may need some template filter to convert nebula_graph to NebulaGraph
| @@ -137,6 +137,10 @@ Writer.prototype.createWriteStream = function (options) { | |||
| return new WriteStream(this, options) | |||
| } | |||
|
|
|||
| module.exports.create_operator = function (scheme, options) { | |||
There was a problem hiding this comment.
Can we modify the Operator's constructor API instead of introducing a new API to build the operator?
There was a problem hiding this comment.
we can't since type of Operator is also generated
There was a problem hiding this comment.
Then we need to design new APIs instead of adding another one. Maybe we can impelment Operator class in js instead of exposing from native binding?
There was a problem hiding this comment.
any idea how? do you suggest to wrap all method of Operator?
There was a problem hiding this comment.
any idea how? do you suggest to wrap all method of
Operator?
It seems like a possible approach. I'm not sure if we can have multiple constructors on the Rust side; perhaps we could generate Rust code as well.
There was a problem hiding this comment.
It's getting messy...
I haven't start using nodejs binding yet, maybe I'll try this some days later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
generate types for nodejs binding.
type of
Operatoris already generated and it's hard to interactive, so we will need to add a new typed functioncreate_operatorto create operator.Are there any user-facing changes?
Yes, new typed method
create_operator.