refactor(dev): use minijinja #5494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
requested review from
messense,
Zheaoli,
Xuanwo and
PsiACE
as code owners
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
force-pushed
the
use-minijinja
branch
from
142644b to
8b54b71
Compare
Signed-off-by: tison <wander4096@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to write up a config generate for java also.
And I'd use minijinja as the template engine which is authored by one of the major maintainer of Jinja (@mitsuhiko).
Rinjia looks interesting for writing Rust expr in the template engine but it looks in an early stage that the wire under the hook is still unstable, while minijinja has robust community use cases.
The newline added is intended that I'd separate each generated
__init__methods.