Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate java configs #5503

Merged
merged 6 commits into from
Jan 3, 2025
Merged

feat: generate java configs #5503

merged 6 commits into from
Jan 3, 2025

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Jan 3, 2025

See the changeset.

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun force-pushed the generate-java-configs branch from 53801e1 to faab314 Compare January 3, 2025 10:39
@tisonkun
Copy link
Member Author

tisonkun commented Jan 3, 2025

just's result is not the final result. I manually run ./mvnw spotless:apply and format the file with Intellij IDEA to populate <p>.

This is a bit awkward but I suppose the config class is relatively stable. Perhaps after Java support docs in markdown and our library reach that minimum version (a couple of years later? 🤣 ), things would change.

UPDATE: Or instead, find a way to convert rustdoc in markdown to javadoc.

@Xuanwo
Copy link
Member

Xuanwo commented Jan 3, 2025

This is a bit awkward but I suppose the config class is relatively stable.

This is fine as a starting point. However, in the near future, we will run just generate in CI to ensure there are no external changes to those files. Is the Javadoc requirement optional? Will it work if we only run just generate java && ./mvnw spotless:apply?

@tisonkun
Copy link
Member Author

tisonkun commented Jan 3, 2025

Not exactly. But I can help in make a reasonable stable version at that time.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tisonkun for this. I have wanted it for so long, and it has finally come true.

@Xuanwo Xuanwo merged commit c866d4b into main Jan 3, 2025
70 checks passed
@Xuanwo Xuanwo deleted the generate-java-configs branch January 3, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants