HDDS-10374. Make container scanner generate merkle trees during the scan #7490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anner-builds-mt * HDDS-10239-container-reconciliation: HDDS-10928. Implement container comparison logic within datanodes. (apache#7293)
Missing chunks are incorrectly reported as corrupted
Metadata scanner integration tests are passing
aswinshakil
reviewed
Jan 9, 2025
| Should Not Be Equal As Strings 0 ${data_checksum} | ||
| Container checksums should match ${container} ${data_checksum} | ||
| # Check that reconcile CLI returns success. Without fault injection, there is no change expected to the | ||
| # container's checksums to inidcate it made a difference |
There was a problem hiding this comment.
Suggested change
| # container's checksums to inidcate it made a difference | |
| # container's checksums to indicate it made a difference |
| @@ -1348,7 +1358,6 @@ public void markContainerUnhealthy(Container container, ScanResult reason) | |||
| } finally { | |||
| container.writeUnlock(); | |||
| } | |||
| createContainerMerkleTree(container); | |||
There was a problem hiding this comment.
If a container moves from OPEN to UNHEALTHY state we should try to build a merkle tree with whatever data we have at the moment before the scanner builds the actual merkle tree. If for some reason (either metadata/data error) we are unable to build it, then we can log the exception and move.
| new File(containerDataFromDisk.getChunksPath()), new IOException("Missing chunk file " + | ||
| chunkFile.getAbsolutePath())); | ||
| blockErrors.add(error); | ||
| } | ||
| } else if (chunk.getChecksumData().getType() != ContainerProtos.ChecksumType.NONE) { | ||
| currentTree.addBlock(block.getBlockID().getLocalID()); |
There was a problem hiding this comment.
Can we not add the block when we add the first chunk?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Summary
Allow the container scanner to update the container Merkle Tree with the currently calculated hashes of what is on disk. If the tree does not already exist, it will be created. Even if the container is unhealthy, the merkle tree should still be updated to reflect the current state of the container. Hashes stored in RocksDB that were given by the client during write will not be modified.
What is the link to the Apache JIRA
HDDS-10374
How was this patch tested?
KeyValueContainerCheckmodifiedMore robust testing of fault combinations will be added later using the framework being developed under HDDS-11942