Skip to content

Commit

Permalink
Investigate a frequently flaky CI failure in GrpcExceptionHandlerSpec (
Browse files Browse the repository at this point in the history
…#293)

* Investigate a frequently flaky CI failure in GrpcExceptionHandlerSpec

* update doc
  • Loading branch information
laglangyue authored Apr 13, 2024
1 parent 5e070ae commit 92a0577
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions docs/src/main/paradox/server/details.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@ For an overview of gRPC status codes and their meaning see [statuscodes.md](http
For unary responses:

Scala
: @@snip[GrpcExceptionHandlerSpec](/interop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/GrpcExceptionHandlerSpec.scala) { #unary }
: @@snip[GrpcExceptionDefaultHandleSpec](/interop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/GrpcExceptionDefaultHandleSpec.scala) { #unary }

Java
: @@snip[ExceptionGreeterServiceImpl](/interop-tests/src/test/java/example/myapp/helloworld/grpc/ExceptionGreeterServiceImpl.java) { #unary }

For streaming responses:

Scala
: @@snip[GrpcExceptionHandlerSpec](/interop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/GrpcExceptionHandlerSpec.scala) { #streaming }
: @@snip[GrpcExceptionDefaultHandleSpec](/interop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/GrpcExceptionDefaultHandleSpec.scala) { #streaming }

Java
: @@snip[ExceptionGreeterServiceImpl](/interop-tests/src/test/java/example/myapp/helloworld/grpc/ExceptionGreeterServiceImpl.java) { #streaming }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ import org.scalatest.wordspec.AnyWordSpecLike

import scala.concurrent.{ ExecutionContext, Future }

class GrpcExceptionHandlerSpec
extends TestKit(ActorSystem("GrpcExceptionHandlerSpec"))
class GrpcExceptionDefaultHandleSpec
extends TestKit(ActorSystem("GrpcExceptionDefaultHandleSpec"))
with AnyWordSpecLike
with Matchers
with ScalaFutures {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ class GrpcExceptionHandlerSpec extends AnyWordSpec with Matchers with ScalaFutur

val otherTypes: Seq[Throwable] = Seq(
new GrpcServiceException(status = Status.DEADLINE_EXCEEDED),
new NotImplementedError,
new UnsupportedOperationException,
new NullPointerException,
new RuntimeException,
new NotImplementedError(),
new UnsupportedOperationException(),
new NullPointerException(),
new RuntimeException(),
new StatusRuntimeException(io.grpc.Status.DEADLINE_EXCEEDED))

val executionExceptions: Seq[Throwable] =
Expand Down

0 comments on commit 92a0577

Please sign in to comment.