Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename excludes dir #180

Closed
wants to merge 1 commit into from
Closed

rename excludes dir #180

wants to merge 1 commit into from

Conversation

pjfanning
Copy link
Contributor

These MIMA excludes are associated with 1.1.x release changes

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this change is needed?

From https://github.com/apache/pekko/blob/main/CONTRIBUTING.md#binary-compatibility:

"If the violation can be ignored add exclude statements from the mima output to a new file named <module>/src/main/mima-filters/<last-version>.backwards.excludes/<pr-or-issue>-<issue-number>-<description>.excludes"

In other words it looks like the excludes directory should be named after the newest version that is incompatible with the current version. In this case 1.0.x seems correct then, as we expect to release 1.1.0 with this incompatible change, so we expect all 1.0.x versions to be incompatible with 1.1.0 and later.

@pjfanning pjfanning marked this pull request as draft December 6, 2024 13:11
@pjfanning
Copy link
Contributor Author

I wouldn't be surprised if we have some excludes that do not follow the standard described in #180 (review) but I'll close this.

@pjfanning pjfanning closed this Dec 6, 2024
@pjfanning pjfanning deleted the rename-dir branch December 6, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants