Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SemVer #99

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Remove SemVer #99

merged 1 commit into from
Mar 24, 2024

Conversation

mdedetrich
Copy link
Contributor

Due to #90

@mdedetrich
Copy link
Contributor Author

@pjfanning Should I go ahead and merge this as its related to an issue you are talking about?

@pjfanning
Copy link
Contributor

I'm neutral on this. The change proposed in #90 is not massively impacting but I don't mind if we change the semver setting.

@mdedetrich
Copy link
Contributor Author

I would like to see #90 done as it implied there is a legitimate reason why it was changed to Long. I'll merge this when I get home

@pjfanning
Copy link
Contributor

@mdedetrich R2dbcExecutor is documented to be an internal class. For me, this means we can change its return types without too much fanfare.

@pjfanning
Copy link
Contributor

pjfanning commented Mar 23, 2024

Maybe we should work out how big the changes in #101 will be before we decide if we need this.

So far the public API changes are only in pekko-projection-r2dbc and not in the pekko-persistence-r2dbc module - maybe we could just remove semver marker from pekko-projection-r2dbc.

@mdedetrich
Copy link
Contributor Author

Maybe we should work out how big the changes in #101 will be before we decide if we need this.

So far the public API changes are only in pekko-projection-r2dbc and not in the pekko-persistence-r2dbc module - maybe we could just remove semver marker from pekko-projection-r2dbc.

Sure, do you want to go ahead with the PR to find out?

@gstein gstein removed their request for review March 24, 2024 02:38
@gstein
Copy link
Member

gstein commented Mar 24, 2024

I removed myself as a reviewer. That was uncool @mdedetrich.

@mdedetrich
Copy link
Contributor Author

I removed myself as a reviewer. That was uncool @mdedetrich.

Apologies, this was an accident as there is another greg as part of committers.

@mdedetrich mdedetrich merged commit b3924ca into apache:main Mar 24, 2024
20 checks passed
@mdedetrich mdedetrich deleted the remove-semver branch March 24, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants