Skip to content

Commit

Permalink
Attempt to clarify why we mention Kerberos and Hadoop Auth in comments
Browse files Browse the repository at this point in the history
  • Loading branch information
epugh committed Dec 2, 2024
1 parent 52adc6f commit d4a905d
Showing 1 changed file with 6 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,12 @@ private void authenticateRequest(
// trivial impl here to keep existing code happy while making the flow clearer. Chain will
// be called after this method completes. Eventually auth all moves to its own filter
// (hopefully). Most auth plugins simply return true after calling this anyway, so they
// obviously don't care. Kerberos plugins seem to mostly use it to satisfy the api of a
// obviously don't care.
//
// The Hadoop Auth Plugin was removed in SOLR-17540, however leaving the below reference
// for future readers, as there may be an option to simplify this logic.
//
// Kerberos plugins seem to mostly use it to satisfy the api of a
// wrapped instance of javax.servlet.Filter and neither of those seem to be doing anything
// fancy with the filter chain, so this would seem to be a hack brought on by the fact that
// our auth code has been forced to be code within dispatch filter, rather than being a
Expand Down

0 comments on commit d4a905d

Please sign in to comment.