SOLR-17074 - Not correctly escaped quote in bin/solr script #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpoerschke
reviewed
Jan 16, 2024
There was a problem hiding this comment.
Thanks @freedev for contributing this pull request!
Would you also like to add an entry in the 9.5.0 Bug Fixes section of solr/CHANGES.txt for this change?
solr/bin/solr
Outdated
| @@ -422,7 +422,7 @@ function print_usage() { | |||
| echo "" | |||
| echo " -noprompt Don't prompt for input; accept all defaults when running examples that accept user input" | |||
| echo "" | |||
| echo " -force If attempting to start Solr as the root user, the script will exit with a warning that running Solr as "root" can cause problems." | |||
| echo " -force If attempting to start Solr as the root user, the script will exit with a warning that running Solr as \"root\" can cause problems." | |||
| echo " It is possible to override this warning with the `-force` parameter." | |||
There was a problem hiding this comment.
Suggested change
| echo " It is possible to override this warning with the `-force` parameter." | |
| echo " It is possible to override this warning with the '-force' parameter." |
There was a problem hiding this comment.
I've added in my PR
epugh
requested changes
Jan 16, 2024
cpoerschke
reviewed
Jan 18, 2024
Comment on lines
+177
to
+178
| * SOLR-17074: Fixed not correctly escaped quote in bin/solr script (Dominique Béjean, Vincenzo D'Amore) | ||
|
|
There was a problem hiding this comment.
Thanks @freedev for iterating on this pull request! I've moved the entry to the 9.5 section here and added attribution for both yourself and Dominique as reporter of the issue.
Please let us know if you'd prefer a different attribution e.g. see line 175 above, some folks use their handle and others their name.
cpoerschke
approved these changes
Jan 18, 2024
asfgit
pushed a commit
that referenced
this pull request
Jan 22, 2024
(cherry picked from commit a7441c1)
freedev
added a commit
to freedev/solr
that referenced
this pull request
Jan 26, 2024
* main: (27 commits) Update protected-branches to include branch_9_5 (apache#2211) SOLR-16397: Tweak v2 'REQUESTSTATUS' API to be more REST-ful (apache#2144) SOLR-17120: handle null value when merging partials (apache#2214) SOLR-17119: Fix exception swallowing in /cluster/plugins (apache#2202) SOLR-15960 Cut over System.getProperty() to EnvUtils for modules (apache#2193) Final fix for node problems (apache#2208) SOLR-16397: Fix warning in merge-indices docs Fix nodeSetup, use node distBaseUrl instead of registry (apache#2208) Add next minor version 9.6.0 SOLR-17089: Upgrade Jersey to 3.1.5 (apache#2178) solr-ref-guide: fix typo in result-clustering.adoc (apache#2210) SOLR-17074: Fixed not correctly escaped quote in bin/solr script (apache#2200) SOLR-15960: Rename getProp as getProperty (apache#2194) Add npmRegistry for nodeSetup as well (apache#2208) Give NPM registry option for downloading node tools (apache#2208) SOLR-17116: Fix INSTALLSHARDDATA async reporting (apache#2188) SOLR-17066: Replace 'data store' term in code and docs (apache#2201) SOLR-17121: Fix SchemaCodecFactory to get PostingsFormat and DocValues from field. (apache#2206) Sync CHANGES for 9.4.1 Add bugfix version 9.4.1 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17074
Description
fixed the script
solr/bin/solrSolution
Added the missing quotes
Tests
Tried to run the script locally, now the output is correct.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.