-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-17579: Refactoring suggested by IDE in ReplicationHandler and tests #2893
Conversation
Typos, some dead methods and dead variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if it is fine to remove the public static final field LOCAL_ACTIVITY_DURING_REPLICATION
, but besides that, everything else looks fine.
The assertion was a great finding though.
// data | ||
// loss | ||
// don't commit on leader version zero for PULL replicas as PULL should only get its index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dang it, I trusted gw tidy
too much..
@@ -164,7 +164,8 @@ Dependency Upgrades | |||
|
|||
Other Changes | |||
--------------------- | |||
(No changes) | |||
* SOLR-17579: Remove unused code and other refactorings in ReplicationHandler and tests. Removed unused public |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
honestly, would any reader of CHANGES.txt care? I'm not questioning your effort in this PR but ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i went back and forth on it, since I'd created a JIRA... I then thought, it should then go in Changes... Plus removing a public variable...
We do need to add to our dev docs a concise "this is what Changes" is for...
Typos, some dead methods and dead variables.
https://issues.apache.org/jira/browse/SOLR-17579
Description
Intellij suggested some fixes.
Solution
Do them and run tests
Tests
existing