SOLR-16390: fix flaky test ClusterPropsAPITest.testClusterPropertyOpsAllGood #2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AllGood The test fails when SSL in enabled, because of testing framework that set 'urlScheme' cluster property. This change updates the test to ignore existing cluster properties.
epugh
approved these changes
Dec 10, 2024
dsmiley
approved these changes
Dec 10, 2024
| assertEquals( | ||
| testClusterProperty, | ||
| (String) ((List<?>) getObjectByPath(o, true, "clusterProperties")).get(0)); | ||
| assertEquals(initCount + 1, ((List<?>) getObjectByPath(o, true, "clusterProperties")).size()); |
There was a problem hiding this comment.
IMO this test shouldn't bother checking the size; it need only check that the entry it's expecting is there or is not there. Hamcrest test utils helps. I did this a day or two ago in this test:
There was a problem hiding this comment.
Good point. I'm updating the test to check the property exists instead of counting.
dsmiley
approved these changes
Dec 10, 2024
|
Sorry all for the bug - thanks for fixing this @psalagnac (and for reviewing, David and Eric!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16390
(linking to the Jira that introduced the test)
Description
The test fails when SSL is enabled, because of testing framework that set 'urlScheme' cluster property.
I was looking at the failure in another PR, and it seems this test fails quite often since #2788. I don't think it is tracked somewhere else.
Solution
This change updates the test to ignore existing cluster properties.
Tests
n/a