Clarify comment since examples do not use a special directory #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malliaridis
reviewed
Dec 18, 2024
There was a problem hiding this comment.
I believe the comment is not relevant anymore and can be removed in the context of this PR, as I could not find any explicit reference in the examples that make use of a logs4j.xml file.
It is worth noting that there is an issue related to SOLR_LOGS_DIR on Windows that I reported in SOLR-17598.
The missing test coverage for Windows is really a pain.
|
Thanks for confirming this... Yeah, no test structure sucks. Hopefully htough, as we work out the set of changes that we introduced in 9.7 and 9.8 that things will calm down.... |
epugh
added a commit
that referenced
this pull request
Dec 18, 2024
(cherry picked from commit 61609b1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17556
Spotted this comment, that I believe is no longer valid since SOLR-17556 was first commented. I sort of wanted to delete the entire bit of logic, but decided it needs to stay...?
@malliaridis would love your eyes...