-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-17602: Per-Module Dependency Locking #2925
Draft
malliaridis
wants to merge
11
commits into
apache:main
Choose a base branch
from
malliaridis:feature/SOLR-17602/per-module-dependency-locking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a27855a
Introduce platform module
malliaridis 6bce484
Cleanup version catalog
malliaridis 2d195bd
Fix dependency conflicts when errorprone enabled
malliaridis 5cdbd20
Add comment about platform module
malliaridis 1fc5df7
Merge remote-tracking branch 'apache/main' into feature/optimize-depe…
malliaridis 41ca82c
Enable per-module dependency lockfiles
malliaridis 721f0aa
Fix renderJavaDoc task dependencies for platform
malliaridis 9cf9d80
Add lockfile for llm module
malliaridis 7128d69
Merge remote-tracking branch 'apache/main' into feature/SOLR-17602/pe…
malliaridis b577da6
Generate lock files with errorprone enabled
malliaridis 984c0c7
Support the common usage of write-locks
malliaridis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# This is a Gradle generated file for dependency locking. | ||
# Manual edits can break the build and are not advised. | ||
# This file is expected to be part of source control. | ||
commons-cli:commons-cli:1.5.0=ratDeps | ||
commons-io:commons-io:2.11.0=ratDeps | ||
junit:junit:3.8.1=javacc | ||
net.java.dev.javacc:javacc:7.0.12=javacc | ||
org.apache.commons:commons-collections4:4.4=ratDeps | ||
org.apache.commons:commons-compress:1.21=ratDeps | ||
org.apache.commons:commons-lang3:3.12.0=ratDeps | ||
org.apache.rat:apache-rat-api:0.15=ratDeps | ||
org.apache.rat:apache-rat-core:0.15=ratDeps | ||
org.apache.rat:apache-rat-tasks:0.15=ratDeps | ||
org.apache.rat:apache-rat:0.15=ratDeps | ||
org.eclipse.jdt:ecj:3.39.0=ecjDeps | ||
empty= |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in groovy I think this can be
it?.enabled == true
and maybe not even need the== true
part