Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renovate.json to work with version catalogs #2936

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

malliaridis
Copy link
Contributor

@malliaridis malliaridis commented Jan 4, 2025

Description

With the version catalogs the solrbot stopped working, and we considered switching to dependabot (see #2880). Since the switch to dependabot is not straight-forward and was proven difficult, we may update solrbot to work with version catalogs.

Solution

This solution updates the renovate.json file, adds the version catalog file to the includePaths and executes the writeLocks task before updating licenses, as this step was also changed during the migration to version catalogs.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@malliaridis malliaridis requested a review from janhoy January 4, 2025 11:50
@janhoy janhoy merged commit 328cce6 into apache:main Jan 6, 2025
3 checks passed
@janhoy
Copy link
Contributor

janhoy commented Jan 6, 2025

Triggering a solrbot run to test...

@janhoy
Copy link
Contributor

janhoy commented Jan 6, 2025

#2937 failed writeLocks:

Command failed: ./gradlew --console=plain --dependency-verification lenient -q :dependencies :solr:dependencies :solr:api:dependencies :solr:benchmark:dependencies :solr:core:dependencies :solr:cross-dc-manager:dependencies :solr:distribution:dependencies :solr:docker:dependencies :solr:documentation:dependencies :solr:example:dependencies :solr:modules:dependencies :solr:packaging:dependencies :solr:prometheus-exporter:dependencies :solr:server:dependencies :solr:solr-ref-guide:dependencies :solr:solrj:dependencies :solr:solrj-streaming:dependencies :solr:solrj-zookeeper:dependencies :solr:test-framework:dependencies :solr:webapp:dependencies :solr:modules:analysis-extras:dependencies :solr:modules:clustering:dependencies :solr:modules:cross-dc:dependencies :solr:modules:extraction:dependencies :solr:modules:gcs-repository:dependencies :solr:modules:hdfs:dependencies :solr:modules:jwt-auth:dependencies :solr:modules:langid:dependencies :solr:modules:llm:dependencies :solr:modules:ltr:dependencies :solr:modules:opentelemetry:dependencies :solr:modules:s3-repository:dependencies :solr:modules:scripting:dependencies :solr:modules:sql:dependencies --update-locks org.apache.hadoop:hadoop-hdfs,org.apache.hadoop:hadoop-client-runtime,org.apache.hadoop:hadoop-client-minicluster,org.apache.hadoop:hadoop-client-api

FAILURE: Build failed with an exception.

* What went wrong:
Failed to notify task execution graph listener.
> Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient.
(snip)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants