Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue simulation on SMT timeout in enabledness check #2758

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Continue simulation on SMT timeout in enabledness check #2758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6c696b
Continue simulation on SMT timeout
thpani Oct 16, 2023
42d25ca
Update changelog
thpani Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .unreleased/bug-fixes/2758-sim-timeout.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Continue simulation on SMT timeout in enabledness check, see #2758
8 changes: 6 additions & 2 deletions tla-bmcmt/src/main/scala/at/forsyte/apalache/tla/bmcmt/SeqModelChecker.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,12 @@ class SeqModelChecker[ExecutorContextT](
logger.info(s"Step ${trex.stepNo}: Transition #$no is disabled")

case None =>
searchState.onResult(RuntimeError())
return (Set.empty, Set.empty) // UNKNOWN or timeout
if (params.isRandomSimulation) {
logger.info(s"Step ${trex.stepNo}: Transition #$no enabledness is UNKNOWN; assuming it is disabled")
} else {
searchState.onResult(RuntimeError())
return (Set.empty, Set.empty) // UNKNOWN or timeout
}
}
// recover from the snapshot
trex.recover(snapshot.get)
Expand Down
Loading