Upgrade Z3 (restores linux/arm64 support) #3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the legacy parameter `seed` has been removed. If we try to pass it, `Solver.add` fails with ``` com.microsoft.z3.Z3Exception: unknown parameter 'seed' Legal parameters are: ... ``` Only `random_seed` remains in the list.
konnov
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via the new z3(-turnkey) releases (see Z3Prover/z3#7201 and tudo-aqua/z3-turnkey#18) we finally have support for
linux/arm64.We also stop passing the legacy parameter
seed, which it seems has been removed.If we try to pass it,
Solver.addfails withOnly
random_seedremains in the list.Tests added for any new codemake fmt-fix(or had formatting run automatically on all files edited)Documentation added for any new functionality./unreleased/for any new functionality