Use correct internal installation when local ts not found (#97)

* Use correct internal installation when local ts not found Fixes #96 * lint
apexskier · Oct 8, 2020 · 7cd3f9e · 7cd3f9e
1 parent 1aa8797
commit 7cd3f9e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/src/tsLibPath.test.ts b/src/tsLibPath.test.ts
@@ -74,7 +74,9 @@ describe("tsLibPath", () => {
 
     it("uses the extension installation if workspace hasn't been saved", () => {
       (nova.workspace.path as any) = "";
-      expect(getTsLibPath()).toBe("/extension/node_modules/typescript/lib");
+      expect(getTsLibPath()).toBe(
+        "/dependencyManagement/node_modules/typescript/lib"
+      );
     });
 
     it("uses the workspace config", () => {

diff --git a/src/tsLibPath.ts b/src/tsLibPath.ts
@@ -1,3 +1,5 @@
+import { dependencyManagement } from "nova-extension-utils";
+
 function reload() {
   nova.commands.invoke("apexskier.typescript.reload");
 }
@@ -43,7 +45,7 @@ export function getTsLibPath(): string | null {
     );
   } else {
     tslibPath = nova.path.join(
-      nova.extension.path,
+      dependencyManagement.getDependencyDirectory(),
       "node_modules/typescript/lib"
     );
   }

diff --git a/typescript.novaextension/CHANGELOG.md b/typescript.novaextension/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## future
+
+### Fixed
+
+- Fix not using dependency installation correctly
+
 ## v1.8.1
 
 ### Fixed