Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing types #3550

Merged
merged 1 commit into from
Oct 6, 2023
Merged

fix: add missing types #3550

merged 1 commit into from
Oct 6, 2023

Conversation

josedonizetti
Copy link
Contributor

@josedonizetti josedonizetti commented Oct 3, 2023 •
edited
Loading

This PR creates the network types for grpc based on https://github.com/aquasecurity/tracee/blob/main/types/trace/network_trace.go

rafaeldtinoco
rafaeldtinoco approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Events seem like existing ones, the types will have to be translated anyway, so its all good on my side.

@josedonizetti josedonizetti force-pushed the add-missing-args-proto branch 4 times, most recently from a6a8d3e to 3e2eb2a Compare October 5, 2023 23:57
@josedonizetti josedonizetti mentioned this pull request Oct 6, 2023
Merged
@josedonizetti josedonizetti force-pushed the add-missing-args-proto branch from 3e2eb2a to ab76787 Compare October 6, 2023 09:08
@josedonizetti josedonizetti marked this pull request as ready for review October 6, 2023 09:08
@josedonizetti josedonizetti merged commit 782fb4d into aquasecurity:main Oct 6, 2023
25 checks passed
@josedonizetti josedonizetti deleted the add-missing-args-proto branch October 6, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaeldtinoco rafaeldtinoco rafaeldtinoco approved these changes

@yanivagman yanivagman Awaiting requested review from yanivagman

Assignees

@josedonizetti josedonizetti

Labels
backported/v0.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josedonizetti @rafaeldtinoco