Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix k8s default policy #3654

Merged

Conversation

josedonizetti
Copy link
Contributor

Review k8s default policy

Fix #3650

I understood the review was only for kubernetes, correct?

Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaeldtinoco
Copy link
Contributor

I understood the review was only for kubernetes, correct?

I had the impression we would change for both. Problem is that the entrypoint.sh uses the "default" set instead of a policy file enumerating the events it should tracee.

It wouldn't be bad to allow the container to give a "config.yaml" and a "policy" dir through mounted directories (and to have default config.yaml and policy.yaml embedded in the container). WDYT ?

For now I believe we can merge this one.

@rafaeldtinoco rafaeldtinoco merged commit 49d03c0 into aquasecurity:main Nov 2, 2023
1 of 2 checks passed
@josedonizetti josedonizetti deleted the fix-k8s-default-policy branch November 2, 2023 12:35
@rafaeldtinoco
Copy link
Contributor

So the fix for the container image is at: #3687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revise default policy
3 participants