Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin ubuntu:latest for gh runners / trigger magic_write event #4455

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

rscampos
Copy link
Collaborator

@rscampos rscampos commented Dec 18, 2024

1. Explain what the PR does

9e6e4d4 chore(test): use more cmd to trigger magic_write event
e442ebd Revert "chore(GH): pin ubuntu (22.04) version for gh runners"

e442ebd Revert "chore(GH): pin ubuntu (22.04) version for gh runners"

This reverts commit ad74ef5a637b5c6fd1830b12f58a9cb897643762.

2. Explain how to test it

3. Other comments

The GitHub runner currently uses ubuntu:latest (Ubuntu 24.04 LTS), which includes kernel 6.8. Initially, the version of the Ubuntu runner was pinned because Tracee needed to be tested with kernel 6.8.

After conducting tests on kernel 6.8 and confirming that everything worked as expected, the pinning was reverted.

The reason for pinning and later reverting the version was due to two failing integration tests. These tests relied on the command cp /etc/netconfig /tmp/netconfig to generate a magic_write event. However, starting from kernel 6.8, this command no longer triggers a magic_write event. Instead, the tests were updated to use the more command, which works as expected with kernel 6.8.

@geyslan
Copy link
Member

geyslan commented Dec 18, 2024

 --- FAIL: Test_EventFilters/comm:_event:_data:_trace_event_magic_write_set_in_multiple_policies_using_multiple_filter_types (13.13s)
--- PASS: Test_EventFilters/comm:_event:_data:_trace_event_security_mmap_file_using_multiple_filter_types (9.11s)
--- FAIL: Test_EventFilters/comm:_event:_data:_trace_event_security_file_open_and_magic_write_using_multiple_filter_types (14.13s)

Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rscampos rscampos force-pushed the revert_ubuntu_2204_gh_runners branch from 6394ce3 to e442ebd Compare December 19, 2024 14:34
@rscampos rscampos changed the title Revert "chore(GH): pin ubuntu (22.04) version for gh runners" chore: pin ubuntu:latest for gh runners / trigger magic_write event Dec 19, 2024
@aquasecurity aquasecurity deleted a comment from github-actions bot Dec 19, 2024
@rscampos rscampos merged commit 6fda8d0 into aquasecurity:main Dec 19, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants