Add support for providing custom Certificate Autority bundle file #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
their own root certificate bundle file By default the requests module uses the bundle provided by the Certifi module https://certifi.io/en/latest/
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
=========================================
Coverage ? 80.79%
=========================================
Files ? 46
Lines ? 2963
Branches ? 181
=========================================
Hits ? 2394
Misses ? 509
Partials ? 60
Continue to review full report at Codecov.
|
|
https://2.python-requests.org/en/master/api/
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In it's current state, Cabot HTTP checks with SSL validation relies on the Python requests module to handle the SSL validation part.
When it comes to validate the server certificate chain, the requests module must know the CA certificate used to sign the presented server certificate. When one want to use Cabot to check an HTTPS server presenting a server certificate signed by a self-signed CA certificate, we need a mean to provide Cabot (and its requests module) with a CA bundle file containing our own certificate.
The python requests module does not use the OS CA certificates store ; instead it uses its own bundle provided by the Python Certifi module.
Changes
This PR introduces a new optional environment variable:
CABOT_HTTP_CHECK_CA_BUNDLEwhich can be used to specify the path of a custom CA cert bundle file.