Avoid overriding 'server_port' if it's passed explicitly #278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like
user
andpassword
options, I think is better not overridingserver_port
whenserver_url
is passed if it was defined explicitly.Right now:
If we want pass a custom port using
server_url
is necessary include it in the ownserver_url
:This way is less flexible if we need to change the port in the future. This change allow the next: