Prevent issue handler from trying to handle issues on finished pods #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing issues where we'd send events for long finished pods For example a pod that fails - but the pod is kept around for a few days for debugging purposes Once the finished pod reached its activeDeadlineSeconds, the executor would send a failed event and delete the pod We don't need to look for issues on finished pods - and sending events for finished pods is actively confusing to downstream We now filter pods we look for issues on based on their state
d80tb7
approved these changes
Dec 9, 2024
JamesMurkin
deleted the
fix_termination_grace_period_handling_of_finished_jobs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing issues where we'd send events for long finished pods
For example a pod that fails - but the pod is kept around for a few days for debugging purposes
Once the finished pod reached its activeDeadlineSeconds, the executor would send a failed event and delete the pod
We don't need to look for issues on finished pods - and sending events for finished pods is actively confusing to downstream
We now filter pods we look for issues on based on their state