Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makefile to automate tasks #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Luciano-JeonHyunJun
Copy link

Fixes #issuenumber

Check everything which applies

  • I have added the issue number for which this pull request is created.

Copy link
Owner

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR.

I just have added one comment. other than that looks good.

Comment on lines +12 to +21
create-db:
python first_timers/run.py --creds-path credentials.json --db-path data/db.json --only-save --create


fetch-issues:
python first_timers/run.py --creds-path credentials.json --db-path data/db.json --only-save


tweet-issues:
python first_timers/run.py --creds-path credentials.json --db-path data/db.json
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 3 steps should not be part of Makefile. This needs to be done manually and separately as per the requirement during the setup.

Can you remove these 3 steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants