Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Use pure Decimal for _IMMUTABLE_TYPES without Annotated as it breaks instance and class checks #374

Closed
wants to merge 2 commits into from
Closed

🐛 Use pure Decimal for _IMMUTABLE_TYPES without Annotated as it breaks instance and class checks #374

wants to merge 2 commits into from

Conversation

tiangolo
Copy link
Collaborator

🐛 Use pure Decimal for _IMMUTABLE_TYPES without Annotated as it breaks instance and class checks

This makes this test pass:

pytest tests/unit/test_model_type_validation.py -k test_mutable_types_mutables

@art049
Copy link
Owner

art049 commented Nov 21, 2023

This is amazing thank you 😀 🔥

art049 added a commit that referenced this pull request Dec 10, 2023
@art049 @tiangolo
fix: use regular Decimal during type substitution
1d29df3 
Taken from #374

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
@art049 art049 force-pushed the feat/integrate-pydantic-2 branch from 0e2d505 to 1d29df3 Compare December 10, 2023 01:52
@art049 art049 closed this Dec 10, 2023
@tiangolo tiangolo deleted the pydantic-2-subs-gen-fix branch December 10, 2023 10:38
art049 added a commit that referenced this pull request Dec 11, 2023
@art049 @tiangolo
fix: use regular Decimal during type substitution
343b5cb 
Taken from #374

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiangolo @art049