Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access model_fields on class and not instance #510

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Access model_fields on class and not instance #510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions odmantic/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@ def _post_copy_update(self: BaseT) -> None:

Set them as if they were modified to make sure they are saved in the database.
"""
object.__setattr__(self, "__fields_modified__", set(self.model_fields))
object.__setattr__(self, "__fields_modified__", set(self.__class__.model_fields))
for field_name, field in self.__odm_fields__.items():
if isinstance(field, ODMEmbedded):
value = getattr(self, field_name)
Expand Down Expand Up @@ -1006,7 +1006,7 @@ def model_update(
) -> None:
is_primary_field_in_patch = (
isinstance(patch_object, BaseModel)
and self.__primary_field__ in patch_object.model_fields
and self.__primary_field__ in patch_object.__class__.model_fields
) or (isinstance(patch_object, dict) and self.__primary_field__ in patch_object)
if is_primary_field_in_patch:
if (
Expand Down