Add ListPackages() to persistence service
#1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djjuhasz
force-pushed
the
dev/issue-988-add-list-package-method
branch
from
cdda311 to
0a12381
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1031 +/- ##
==========================================
+ Coverage 54.22% 54.31% +0.09%
==========================================
Files 103 103
Lines 5957 5995 +38
==========================================
+ Hits 3230 3256 +26
- Misses 2475 2485 +10
- Partials 252 254 +2 ☔ View full report in Codecov by Sentry. |
djjuhasz
force-pushed
the
dev/issue-988-add-list-package-method
branch
from
0a12381 to
ae41938
Compare
Refs #988 This continues the work toward #988 by adding a `ListPackages()` method to the persistence service that includes a count of the total search results returned (before paging), as well as allowing filtering, sorting, and paging of the search. Other changes: - Add a telemetry wrapper for the `ListPackages()` method to provide extra performance and debugging data - Add additional commentary for the `Filter.Page()` method - Add many unit tests for the `ListPackages()` functionality
djjuhasz
force-pushed
the
dev/issue-988-add-list-package-method
branch
from
3644b66 to
f69f41c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #988
This continues the work toward #988 by adding a
ListPackages()method to the persistence service that includes a count of the total search results returned (before paging), as well as allowing filtering, sorting, and paging of the search.Other changes:
ListPackages()method to provide extra performance and debugging dataFilter.Page()methodListPackages()functionality