Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite services without authentication #1033

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

jraddaoui
Copy link
Collaborator

Recreate package and storage services for the internal API without overwriting the existing ones used in the public API.

Refs #1032.

@jraddaoui jraddaoui requested a review from djjuhasz October 1, 2024 17:21
@jraddaoui jraddaoui self-assigned this Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.25%. Comparing base (e2cc8b3) to head (f3e0688).

Files with missing lines Patch % Lines
cmd/enduro/main.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1033      +/-   ##
==========================================
+ Coverage   54.22%   54.25%   +0.03%     
==========================================
  Files         103      103              
  Lines        5957     5957              
==========================================
+ Hits         3230     3232       +2     
+ Misses       2475     2474       -1     
+ Partials      252      251       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jraddaoui jraddaoui force-pushed the dev/issue-1032-auth-regression branch from f3e0688 to 5f20698 Compare October 1, 2024 17:39
Copy link
Collaborator

@djjuhasz djjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Recreate package and storage services for the internal API without
overwriting the existing ones used in the public API.

[skip-codecov]
@jraddaoui jraddaoui force-pushed the dev/issue-1032-auth-regression branch from 5f20698 to 846f026 Compare October 1, 2024 23:02
@jraddaoui jraddaoui merged commit 846f026 into main Oct 1, 2024
13 checks passed
@jraddaoui jraddaoui deleted the dev/issue-1032-auth-regression branch October 1, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants