-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add poststorage child workflows #1061
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jraddaoui. I had a couple of thoughts, but one doesn't require any changes. I think you need to address what happens if the poststorage workflow is called with an a3m vs. AM preservation system.
Yes, if a child workflow only works with AM and Enduro is configured to run with a3m, I'd prefer that child workflow to fail to know I misconfigured the system. As I said, we may want to improve that at some point to be able to report the child workflows in the API/UI. For now they are just like webhooks to be able to trigger custom workflows after storage, and we only make sure those workflows are started by Temporal. Those workflows can be monitored elsewhere for now, until we decide if we want to add information about them in the API/UI. I'll add some tests and ping you for a final review. |
ae5f3d1
to
893c867
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
==========================================
+ Coverage 54.55% 54.74% +0.19%
==========================================
Files 103 104 +1
Lines 7512 7632 +120
==========================================
+ Hits 4098 4178 +80
- Misses 3164 3198 +34
- Partials 250 256 +6 ☔ View full report in Codecov by Sentry. |
893c867
to
12ec6a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Allow to configure a set of poststorage child workflows that will be started after AIP storage. These workflows will receive the AIPUUID as a parameter and the parent workflow will only wait for them to be started by Temporal. They are started with a disconnected context and using the abandon parent close policy, so they can continue running after the parent workflow finishes, therefore their results are ignored.
12ec6a6
to
a8191df
Compare
Allow to configure a set of poststorage child workflows that will be
started after AIP storage. These workflows will receive the AIPUUID
as a parameter and the parent workflow will only wait for them to be
started by Temporal. They are started with a disconnected context and
using the abandon parent close policy, so they can continue running
after the parent workflow finishes, therefore their results are ignored.
Refs #886.