Add about dialog to dashboard #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1082 +/- ##
==========================================
+ Coverage 54.69% 54.82% +0.12%
==========================================
Files 105 105
Lines 7696 7696
==========================================
+ Hits 4209 4219 +10
+ Misses 3228 3221 -7
+ Partials 259 256 -3 ☔ View full report in Codecov by Sentry. |
|
Work in progress:
Clicking on the top-right info icon will show that dialog. I still need to add some template and style to get closer to the wireframes from the issue. Moving the user menu to a drop-down including a link to the dialog will probably happen in another PR. |
jraddaoui
commented
Nov 27, 2024
djjuhasz
reviewed
Nov 27, 2024
djjuhasz
approved these changes
Nov 27, 2024
mcantelon
approved these changes
Nov 28, 2024
jraddaoui
force-pushed
the
dev/issues-1062-about-ui
branch
from
e9d1e6a to
5cc9617
Compare
jraddaoui
changed the title
jraddaoui
force-pushed
the
dev/issues-1062-about-ui
branch
from
5cc9617 to
53ed84b
Compare
jraddaoui
force-pushed
the
dev/issues-1062-about-ui
branch
from
53ed84b to
006eb3b
Compare
jraddaoui
commented
Nov 28, 2024
There was a problem hiding this comment.
@djjuhasz @mcantelon ready for another review if you have some time. Check #1062 (comment) for more details and screenshots.
djjuhasz
approved these changes
Nov 28, 2024
- Update API generated code and client to include about service. - Add info icon to the header to open a dialog with about information. - Show information from the about API endpoint (version, pres. system, child workflow names), include the same text from the homepage and buttons to documentation, license and contributing. Unrelated changes: - Make sure padding is not added to the body when a dialog is shown. - Bold "Enduro" in the header to match dialog. - Update homepage text to match dialog. - Redirect to signin page after API authentication error.
jraddaoui
force-pushed
the
dev/issues-1062-about-ui
branch
from
006eb3b to
6ecb34b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
child workflow names), include the same text from the homepage and
buttons to documentation, license and contributing.
Unrelated changes:
Refs #1062.