Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): Fix typo in vault and consul service paths #188

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

lucasadrianof
Copy link
Contributor

Fixing the services/${SERVICE_NAME}/${SERVICE_ENV} Consul and Vault paths to /services, it was previously set to /service. I double-checked the source code, and it expects the plural version of the word in both cases.

I also fixed a small typo in the example where a vault secret is set.

@lucasadrianof lucasadrianof requested a review from a team as a code owner January 16, 2024 20:04
@lucasadrianof lucasadrianof merged commit 763fe91 into main Jan 16, 2024
3 checks passed
@lucasadrianof lucasadrianof deleted the docs/fix-readme-typo branch January 16, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants