Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vault)!: remove support for ENCRYPTED_VAULT_TOKEN #251

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

mloberg
Copy link
Contributor

@mloberg mloberg commented Dec 17, 2024

This is not a feature we use anymore

BREAKING CHANGE: remove Vault auth support for ENCRYPTED_VAULT_TOKEN

This is not a feature we use anymore

BREAKING CHANGE: remove Vault auth support for ENCRYPTED_VAULT_TOKEN
@mloberg mloberg marked this pull request as ready for review December 17, 2024 15:22
@mloberg mloberg requested a review from a team as a code owner December 17, 2024 15:22
Copy link
Contributor

@dholmes dholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't know if this was or was not in use, but looks super easy to bring back if we had to.

@mloberg mloberg merged commit 1837d21 into main Dec 17, 2024
3 checks passed
@mloberg mloberg deleted the feature/remove-kms branch December 17, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants