Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit typos & codespell hooks #7724

Draft
wants to merge 1 commit into
base: RC_2_0
Choose a base branch
from

Conversation

xavier2k6
Copy link
Contributor

Testing for typo's etc.

example:

verisoning -> versioning

# when the verisoning scheme changed from year to (low) version numbers.

@xavier2k6 xavier2k6 force-pushed the lbt-ci-hooks-typos-spell branch from a06b999 to 9228ab8 Compare August 7, 2024 08:50
@xavier2k6 xavier2k6 force-pushed the lbt-ci-hooks-typos-spell branch from 9228ab8 to 5f0cfda Compare August 31, 2024 10:26
@arvidn
Copy link
Owner

arvidn commented Sep 30, 2024

there are a lot of good fixes here. if only it could be made to ignore string literals. ignoring the .torrent files is easy enough

@xavier2k6
Copy link
Contributor Author

xavier2k6 commented Sep 30, 2024

certain words etc. can be excluded.....will be back to it...any suggestions on what you'd like to exclude or want to actually change?

leafs -> leaves
file_prioritity0 -> file_priority0
file_prioritity1 -> file_priority1

@arvidn
Copy link
Owner

arvidn commented Sep 30, 2024

the most obvious false positives were in string literals in the c++ code, in the utf-8 test file and in .torrent files. Maybe also in some .xml files.

@xavier2k6 xavier2k6 force-pushed the lbt-ci-hooks-typos-spell branch from 5f0cfda to 1e968fd Compare October 3, 2024 13:13
@xavier2k6 xavier2k6 force-pushed the lbt-ci-hooks-typos-spell branch from 1e968fd to fe5a1c3 Compare October 13, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants