Treat empty strings as generic for column type deduction, allow thousands separators #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjkundert
changed the title
|
I think you should split your PR in two:
Indeed, merging the fix should not be conditional to accepting/merging your proposed modification. |
pjkundert
force-pushed
the
feature-empties
branch
2 times, most recently
from
6c310a0 to
887861d
Compare
pjkundert
changed the title
|
OK, removed SEPARATING_LINE fix. Now, deals in deduction of int and float columns, and supports thousands-separators in ints, floats. |
o Empty/None values are ignored for deducing the type of a column o Comma-separated numbers are allowed in for int and float types
pjkundert
force-pushed
the
feature-empties
branch
from
887861d to
8c9c9e7
Compare
|
Please consider merging this one, @astatin. It correctly deduces the types of int and float values with comma-separators (important!), and also correctly deduces the types of columns with empty cells (very important for bigger tables with complex data and missing values!) Thanks for all your work on this! |
|
@pjkundert I think this can be merged. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow missing (None) and empty ("") cells to be treated the same, for the purposes of deducing the column type.
This allows us to have empty cells (without the
missingval), differentiated from missing cells (with themissingval), for columns generally containing numeric data, while retaining the correctly deduced column formatting.Resolves #242