Unpin Numpy version for building wheels #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
=======================================
Coverage 88.27% 88.27%
=======================================
Files 6 6
Lines 503 503
=======================================
Hits 444 444
Misses 59 59 ☔ View full report in Codecov by Sentry. |
Allow using any version of Numpy between 1.25 and 2. This will allow us to use the latest release of Numpy on PyPI and take advantage of prebuilt wheels for more platforms and architectures. Use the new `NPY_TARGET_VERSION` macro to peform a backward-compatible supporting versions of Numpy as old as 1.19.
lpsinger
force-pushed
the
unpin-numpy-build-requires
branch
from
25b68cb to
6b98327
Compare
pllim
reviewed
Nov 21, 2023
There was a problem hiding this comment.
I'll let @astrofrog approve since I am not a maintainer of this repo but the diff LGTM. Thanks!
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
astrofrog
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow using any version of Numpy between 1.25 and 2. This will allow us to use the latest release of Numpy on PyPI and take advantage of prebuilt wheels for more platforms and architectures.
Use the new
NPY_TARGET_VERSIONmacro to peform a backward-compatible supporting versions of Numpy as old as 1.19.