Merge pull request #420 from atlanhq/DVX-777

DVX-777: Added `username` and extra `fields` to the `CredentialResponse`

pyatlan/model/credential.py

@@ -72,13 +72,14 @@ class CredentialResponse(AtlanObject):
     metadata: Optional[Dict[str, Any]]
     level: Optional[Dict[str, Any]]
     connection: Optional[Dict[str, Any]]
+    username: Optional[str]
+    extras: Optional[Dict[str, Any]] = Field(default=None, alias="extra")
 
     def to_credential(self) -> Credential:
         """
         Convert this response into a credential instance.
-        Note: the username, password, and extras fields
-        must still all be populated, as they will never be
-        returned by a credential lookup (for security reasons).
+        Note: The password field must still be populated manually,
+        as it will never be returned by a credential lookup for security reasons.
         """
         return Credential(
             id=self.id,
@@ -88,6 +89,8 @@ def to_credential(self) -> Credential:
             auth_type=self.auth_type,
             connector_type=self.connector_type,
             connector_config_name=self.connector_config_name,
+            username=self.username,
+            extras=self.extras,  # type: ignore[call-arg]
         )
 
 

tests/unit/test_credential_client.py

@@ -48,7 +48,7 @@ def client(mock_api_caller) -> CredentialClient:
 
 @pytest.fixture()
 def credential_response() -> CredentialResponse:
-    return CredentialResponse(
+    return CredentialResponse(  # type: ignore[call-arg]
         id="test-id",
         version="1.2.3",
         is_active=True,
@@ -67,6 +67,8 @@ def credential_response() -> CredentialResponse:
         metadata=None,
         level=None,
         connection=None,
+        username="test-username",
+        extras={"some": "value"},
     )
 
 
@@ -77,6 +79,8 @@ def _assert_cred_response(cred: Credential, cred_response: CredentialResponse):
     assert cred.auth_type == cred_response.auth_type
     assert cred.connector_type == cred_response.connector_type
     assert cred.connector_config_name == cred_response.connector_config_name
+    assert cred.username == cred_response.username
+    assert cred.extras == cred_response.extras
 
 
 @pytest.mark.parametrize("test_api_caller", ["abc", None])