refactor: functions

avrcoelho · Jun 16, 2022 · 2661dd2 · 2661dd2
1 parent 12ebf2c
commit 2661dd2
Show file tree

Hide file tree

Showing 3 changed files with 61 additions and 80 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-native-hook-notification",
-  "version": "2.2.2",
+  "version": "2.2.3",
   "license": "MIT",
   "main": "dist/main/index.js",
   "typings": "dist/main/index.d.ts",

diff --git a/src/main/index.ts b/src/main/index.ts
@@ -1,4 +1,4 @@
-import { useCallback, useRef } from 'react';
+import { useRef } from 'react';
 import { NotificationStore } from '../presentation/store/NotificationStore';
 import {
   CustomNotificationParams,
@@ -22,78 +22,62 @@ export {
 const notificationStore = NotificationStore.getInstance();
 
 export const useNotification: UseNotificationHook = (hookParams = {}) => {
-  const info = useCallback(
-    (notificationParams: NotificationParams) => {
-      const notification = {
-        ...hookParams,
-        ...notificationParams,
-        type: 'info' as NotificationType,
-      };
-      notificationStore.add(notification);
-    },
-    [hookParams],
-  );
+  const info = (notificationParams: NotificationParams): void => {
+    const notification = {
+      ...hookParams,
+      ...notificationParams,
+      type: 'info' as NotificationType,
+    };
+    notificationStore.add(notification);
+  };
 
-  const success = useCallback(
-    (notificationParams: NotificationParams) => {
-      const notification = {
-        ...hookParams,
-        ...notificationParams,
-        type: 'success' as NotificationType,
-      };
-      notificationStore.add(notification);
-    },
-    [hookParams],
-  );
+  const success = (notificationParams: NotificationParams): void => {
+    const notification = {
+      ...hookParams,
+      ...notificationParams,
+      type: 'success' as NotificationType,
+    };
+    notificationStore.add(notification);
+  };
 
-  const error = useCallback(
-    (notificationParams: NotificationParams) => {
-      const notification = {
-        ...hookParams,
-        ...notificationParams,
-        type: 'error' as NotificationType,
-      };
-      notificationStore.add(notification);
-    },
-    [hookParams],
-  );
+  const error = (notificationParams: NotificationParams): void => {
+    const notification = {
+      ...hookParams,
+      ...notificationParams,
+      type: 'error' as NotificationType,
+    };
+    notificationStore.add(notification);
+  };
 
-  const warning = useCallback(
-    (notificationParams: NotificationParams) => {
-      const notification = {
-        ...hookParams,
-        ...notificationParams,
-        type: 'warning' as NotificationType,
-      };
-      notificationStore.add(notification);
-    },
-    [hookParams],
-  );
+  const warning = (notificationParams: NotificationParams): void => {
+    const notification = {
+      ...hookParams,
+      ...notificationParams,
+      type: 'warning' as NotificationType,
+    };
+    notificationStore.add(notification);
+  };
 
-  const defaultNotification = useCallback(
-    (notificationParams: NotificationParams) => {
-      const notification = {
-        ...hookParams,
-        ...notificationParams,
-        type: 'default' as NotificationType,
-      };
-      notificationStore.add(notification);
-    },
-    [hookParams],
-  );
+  const defaultNotification = (
+    notificationParams: NotificationParams,
+  ): void => {
+    const notification = {
+      ...hookParams,
+      ...notificationParams,
+      type: 'default' as NotificationType,
+    };
+    notificationStore.add(notification);
+  };
 
-  const custom = useCallback(
-    (notificationParams: CustomNotificationParams) => {
-      const notification = {
-        ...hookParams,
-        ...notificationParams,
-        theme: 'custom' as NotificationTheme,
-        type: 'custom' as NotificationType,
-      };
-      notificationStore.add(notification);
-    },
-    [hookParams],
-  );
+  const custom = (notificationParams: CustomNotificationParams): void => {
+    const notification = {
+      ...hookParams,
+      ...notificationParams,
+      theme: 'custom' as NotificationTheme,
+      type: 'custom' as NotificationType,
+    };
+    notificationStore.add(notification);
+  };
 
   return useRef({
     info,

diff --git a/src/presentation/components/Notification/useController.ts b/src/presentation/components/Notification/useController.ts
@@ -210,16 +210,13 @@ export const useController: UseControllerHook = ({
       : {};
   }, [animationEnteringFinish, transitionDirection, limitToRemove]);
 
-  const onFinishAnimation = useCallback(
-    (isFinished: boolean): void => {
-      'worklet';
+  const onFinishAnimation = (isFinished: boolean): void => {
+    'worklet';
 
-      if (isFinished) {
-        runOnJS(toggleAnimationEnteringFinish)();
-      }
-    },
-    [toggleAnimationEnteringFinish],
-  );
+    if (isFinished) {
+      runOnJS(toggleAnimationEnteringFinish)();
+    }
+  };
 
   const delayDecrement = useRef(delay / DELAY);
   const timerRef = useRef<NodeJS.Timeout>();
@@ -244,12 +241,12 @@ export const useController: UseControllerHook = ({
     return () => clearInterval(timerRef.current as NodeJS.Timeout);
   }, [autoClose, isPaused, onExecuteTimer]);
 
-  const onPressNotification = useCallback((): void => {
+  const onPressNotification = (): void => {
     onPress?.();
     if (closeOnPress) {
       onRemove();
     }
-  }, [closeOnPress, onPress, onRemove]);
+  };
 
   const animation = getAnimation({ position, transition });