Add ROCm as alternative to CUDA for plugin use #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhankins
changed the title
ryanhankins
force-pushed
the
merge6
branch
8 times, most recently
from
98282b4 to
064fb2c
Compare
|
@ryanhankins Can you please add to commit message some information on which platforms you have tested this functionality to work properly? |
The nccl_net_ofi_cu* calls map directly to CUDA methods. Instead of this mapping, insert indirection via nccl_net_ofi_gpu methods so that the implementation of the methods depends on CUDA, but the methods themselves can be called for different underling frameworks (such as ROCm). Signed-off-by: Ryan Hankins <ryan.hankins@hpe.com>
ROCm provides an interface similar to CUDA, to work with AMD GPUs.
Provide a compile time option to build with ROCm instead of CUDA.
1. Add --with-rocm= flag to ./configure.
2. Make all CUDA calls "gpu" calls, which are independent of the
underlying framework.
3. Switch between _rocm and _cuda files at compile time to make the
appropriate calls.
4. When building for RCCL (AMD's NCCL), generate a rccl-net.so-named
plugin for binary compatibility.
Tested on:
1. HPE Cray EX with EX235A BardPeak GPUs + 200Gb Slingshot adapters.
2. HPE Cray EX with NVIDIA A100 SXM4 80GB GPUs + 200 Gb Slingshot
adapters.
Signed-off-by: Ryan Hankins <ryan.hankins@hpe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
See commit messages for more detail. Add a --with-rocm flag to configure.ac to switch between CUDA and ROCm GPU calls, to support AMD GPUs. Add code to fiiles to abstract CUDA calls, and, upon the use of the --with-rocm option, to call the ROCm alternatives.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.