fix(type-safe-api): ensure lambda function names do not exceed max le…

…ngth Truncate the lambda function names for the custom resource to ensure they are below the max length of 64 characters. Fixes #615
aws · Oct 30, 2023 · 687bca2 · 687bca2
1 parent d1babf7
commit 687bca2
Show file tree

Hide file tree

Showing 3 changed files with 3,377 additions and 3,339 deletions.
diff --git a/packages/type-safe-api/src/construct/type-safe-rest-api.ts b/packages/type-safe-api/src/construct/type-safe-rest-api.ts
@@ -125,9 +125,12 @@ export class TypeSafeRestApi extends Construct {
 
     const stack = Stack.of(this);
 
-    const prepareSpecLambdaName = `${PDKNag.getStackPrefix(stack)
+    // Lambda name prefix is truncated to 48 characters (16 below the max of 64)
+    const lambdaNamePrefix = `${PDKNag.getStackPrefix(stack)
       .split("/")
-      .join("-")}PrepareSpec${this.node.addr.slice(-8).toUpperCase()}`;
+      .join("-")
+      .slice(0, 40)}${this.node.addr.slice(-8).toUpperCase()}`;
+    const prepareSpecLambdaName = `${lambdaNamePrefix}PrepSpec`;
     const prepareSpecRole = new Role(this, "PrepareSpecRole", {
       assumedBy: new ServicePrincipal("lambda.amazonaws.com"),
       inlinePolicies: {
@@ -210,7 +213,7 @@ export class TypeSafeRestApi extends Construct {
     );
 
     // Create a custom resource for preparing the spec for deployment (adding integrations, authorizers, etc)
-    const prepareSpec = new LambdaFunction(this, "PrepareSpec", {
+    const prepareSpec = new LambdaFunction(this, "PrepareSpecHandler", {
       handler: "index.handler",
       runtime: Runtime.NODEJS_18_X,
       code: Code.fromAsset(
@@ -221,7 +224,7 @@ export class TypeSafeRestApi extends Construct {
       functionName: prepareSpecLambdaName,
     });
 
-    const providerFunctionName = `${prepareSpecLambdaName}-Provider`;
+    const providerFunctionName = `${lambdaNamePrefix}PrepSpecProvider`;
     const providerRole = new Role(this, "PrepareSpecProviderRole", {
       assumedBy: new ServicePrincipal("lambda.amazonaws.com"),
       inlinePolicies: {
@@ -244,7 +247,7 @@ export class TypeSafeRestApi extends Construct {
       },
     });
 
-    const provider = new Provider(this, "PrepareSpecResourceProvider", {
+    const provider = new Provider(this, "PrepareSpecProvider", {
       onEventHandler: prepareSpec,
       role: providerRole,
       providerFunctionName,
@@ -345,7 +348,7 @@ export class TypeSafeRestApi extends Construct {
 
     const prepareSpecCustomResource = new CustomResource(
       this,
-      "PrepareSpecResource",
+      "PrepareSpecCustomResource",
       {
         serviceToken: provider.serviceToken,
         properties: prepareApiSpecCustomResourceProperties,