Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capabilities for Managed Stack #6309

Closed
wants to merge 5 commits into from

Conversation

jysheng123
Copy link
Contributor

@jysheng123 jysheng123 commented Nov 21, 2023

Which issue(s) does this change fix?

#6243

Why is this change necessary?

Some regions (need to investigate why this is the case) have some flaky runs where sometimes the managed stack need special permissions to create that it does not need in normal regions. Note that I say flaky here because I was not able to recreate the error but a fellow developer was able to so there is some mismatch there.

How does it address the issue?

Add the capabilities needed so that it does not matter what region is the stack is being deployed in

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Nov 21, 2023
@jysheng123 jysheng123 marked this pull request as ready for review November 21, 2023 18:22
@jysheng123 jysheng123 requested a review from a team as a code owner November 21, 2023 18:22
@jysheng123
Copy link
Contributor Author

Pull Request is not needed as this is a CFN bug that will be fixed next release on their side.

@jysheng123 jysheng123 closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/internal stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants