Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch not-ok http response codes for sam init #7678

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

mndeveci
Copy link
Contributor

@mndeveci mndeveci commented Nov 13, 2024

Which issue(s) does this change fix?

#7676

Why is this change necessary?

GH is returning 403 for HTTP calls we made to download the manifest file. There is no check at the moment to fallback to cloning the repository.

How does it address the issue?

Checks the response.ok, if it is False it goes through fallback.

What side effects does this change have?

For the customers who faced this issue, listing options for the first time for sam init will be slower since it needs to clone the application templates locally.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci marked this pull request as ready for review November 13, 2024 19:57
@mndeveci mndeveci requested a review from a team as a code owner November 13, 2024 19:57
@mndeveci mndeveci enabled auto-merge November 13, 2024 20:12
@mndeveci mndeveci added this pull request to the merge queue Nov 13, 2024
Merged via the queue into aws:develop with commit 7b723b5 Nov 13, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants