Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved version selection functionality in SageMaker Lifecycle #203

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

michaelnchin
Copy link
Member

@michaelnchin michaelnchin commented Oct 6, 2023

Issue #, if available: N/A

Description of changes:

  • Changed the default behavior of the SageMaker Lifecycle to use the latest release version in ECR. Previously, the latest-SNAPSHOT auto-build version was the default.
  • Improved user selection of specific ECR version tags via the -ev/--explorer-version parameter.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2c4b9a6) 10.01% compared to head (c03ff3d) 10.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #203   +/-   ##
=======================================
  Coverage   10.01%   10.01%           
=======================================
  Files         406      406           
  Lines       30086    30086           
  Branches      655      655           
=======================================
  Hits         3013     3013           
  Misses      26739    26739           
  Partials      334      334           
Flag Coverage Δ
unittests 10.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cubeddu cubeddu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @michaelnchin Thanks!

@michaelnchin michaelnchin merged commit b45bb33 into main Oct 10, 2023
3 checks passed
@michaelnchin michaelnchin deleted the sagemaker-pin-release branch October 10, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants