Synchronization with high number of labels with long strings #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cubeddu
changed the title
Cole-Greer
previously approved these changes
Oct 19, 2023
packages/graph-explorer/src/connector/sparql/SPARQLConnector.ts
Outdated
Show resolved
Hide resolved
michaelnchin
requested changes
Oct 20, 2023
There was a problem hiding this comment.
Thanks @cubeddu ! Nice job on finding a workaround for the header limit. Couple of changes before we merge this in...
michaelnchin
requested changes
Oct 20, 2023
packages/graph-explorer/src/connector/gremlin/GremlinConnector.ts
Outdated
Show resolved
Hide resolved
packages/graph-explorer/src/connector/gremlin/GremlinConnector.ts
Outdated
Show resolved
Hide resolved
* Bump Babel and PostCSS versions * update changelog
* Bump crypto-js to 4.2.0 * update changelog
GET method to useOpenCypher and useGremlin
|
@michaelnchin PR is ready for review. |
charlesivie
previously approved these changes
Nov 24, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
added 7 commits
December 12, 2023 14:29
This commit refactors the `useOpenCypher`, `useGremlin`, `useSPARQL`, and `useGEFetch` functions. It updates the imports to include the `useConfiguration` function from the `core` module. It also modifies the function signatures to remove the `connection` parameter and instead retrieves the connection configuration using `useConfiguration`.
michaelnchin
approved these changes
Jan 5, 2024
cubeddu
added a commit
to cubeddu/graph-explorer
that referenced
this pull request
Jan 8, 2024
* updating fetch for templated queries to be POST * fix linter and pre commit issues * fix linter SelectListBox node.value can be null * changelog * removed method get from fetch as it's defaults to get * Bump Babel, PostCSS, and Vite to latest (aws#210) * Bump Babel and PostCSS versions * update changelog * Bump crypto-js to 4.2.0 (aws#214) * Bump crypto-js to 4.2.0 * update changelog * merge * Bye abstract class hello React hooks, test passing * Fix error messages on schema fetch * server does post calls instead of gets calls to neptune * Fix type imports and update schema state * Fix headers in useGEFetch and useSPARQL, and add GET method to useOpenCypher and useGremlin * Add body-parser middleware, created middleware to sign headers * Refactor ConnectorProvider * Add new connection configuration options * Refactor useOpenCypher, useGremlin, useSPARQL, and useGEFetch This commit refactors the `useOpenCypher`, `useGremlin`, `useSPARQL`, and `useGEFetch` functions. It updates the imports to include the `useConfiguration` function from the `core` module. It also modifies the function signatures to remove the `connection` parameter and instead retrieves the connection configuration using `useConfiguration`. * Update fetch request timeout value * Remove unused import in ConnectorProvider.tsx * Add compression middleware to node-server.js * Refactor aws4SigningMiddleware to use async/await * adjusting header signature * update * IAM api call works for POST * GET call return undefined * Update IAM headers and fix query parameter in useGremlin --------- Co-authored-by: Michael Chin <chnmch@amazon.com> Co-authored-by: Michael Chin <mchin188@yahoo.com> Co-authored-by: Juan Cubeddu <vcubjuan@amzon.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Switching from GET to POST in fetch calls allows the handling of long labels or large data efficiently. Unlike GET, which has URL length limits, POST carries data in the request body, preventing data truncation and ensuring accurate data transmission. This change resolves issues with long labels in URL queries, eliminating risks tied to URL string parameter limits.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.